Fix switch case config validation

pkg/lib/config/sms_provider.go

@@ -149,12 +149,12 @@ var _ = RootSchema.Add("ProviderSelectorSwitchRule", `
 	},
 	"allOf": [
 		{
-			"if": { "properties": { "type": { "const": "phone_number_alpha2" } }},
+			"if": { "properties": { "type": { "const": "match_phone_number_alpha2" } }},
 			"then": { "required": ["phone_number_alpha2"] }
 		},
 		{
-			"if": { "properties": { "type": { "const": "app_id_and_phone_number_alpha2" } }},
-			"then": { "required": ["phone_number_alpha2"] }
+			"if": { "properties": { "type": { "const": "match_app_id_and_phone_number_alpha2" } }},
+			"then": { "required": ["phone_number_alpha2", "app_id"] }
 		}
 	],
 	"required": ["type", "use_provider"]

pkg/lib/config/testdata/authgear-sms-gateway.tests.yaml

@@ -231,3 +231,27 @@ config:
     switch:
       - type: default
         use_provider: twilio
+---
+name: missing-required-fields-in-switch-cases
+error: |-
+  invalid configuration:
+  /provider_selector/switch/0: required
+    map[actual:[type use_provider] expected:[phone_number_alpha2] missing:[phone_number_alpha2]]
+  /provider_selector/switch/1: required
+    map[actual:[type use_provider] expected:[app_id phone_number_alpha2] missing:[app_id phone_number_alpha2]]
+config:
+  providers:
+    - name: twilio
+      type: twilio
+      twilio:
+        account_sid: "my-account-sid"
+        auth_token: "my-auth-token"
+        messaging_service_sid: "my-messaging-service-sid"
+  provider_selector:
+    switch:
+      - type: match_phone_number_alpha2
+        use_provider: twilio
+      - type: match_app_id_and_phone_number_alpha2
+        use_provider: twilio
+      - type: default
+        use_provider: twilio

pkg/lib/sms/selector_test.go

@@ -50,7 +50,7 @@ provider_selector:
       use_provider: p2
       phone_number_alpha2: CN
       app_id: "123"
-    - type: match_app_id_and_phone_number_alpha2
+    - type: match_phone_number_alpha2
       use_provider: p4
       phone_number_alpha2: CN
     - type: default