-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Makers to use pydantic models instead of yamls #307
base: main
Are you sure you want to change the base?
Conversation
Shouldn't we rather do something similar to atomate2 settings? |
Hi @JaGeo , i think both above approach we can use to load the default yamls, which I plan to do next : similar to atomate2 settings But we would still need postinit in the maker if we expect user to provide modified yaml path (so it gets read when the flow is created) and we don't want to copy that yamls to remote cluster. Due to nature of jobflow delayed execution |
@naik-aakash okay! Likely pymatgen approach is th closest to what we want for defaults |
Another thought: post init will not work if you initialize the flow during run time |
@naik-aakash Great. Yes, please go ahead. And thanks @YuanbinLiu and @nfragapane !! |
@@ -603,13 +603,11 @@ def do_rss_iterations( | |||
if include_dimer: | |||
include_dimer = False | |||
|
|||
(mlip_path,) = do_mlip_fit.output["mlip_path"] | |||
|
|||
do_iteration = do_rss_iterations( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the line as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work as output reference cannot be resolved outside a job but rather inside. Have now changed it in the code and it works fine now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was needed which fixes all the issues
@naik-aakash thanks! Some of the fixes were due to my change allowing to finetue on another system than one does DFT |
Closes #305 , #329, #324 and #330
Changes
nequip_fitting
function can be cleaned upmachine_learning_fit
functionM3GNET
andNEQUIP
hyperparametersM3GNET
models