Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kitti2bag #1762

Closed
wants to merge 6 commits into from
Closed

Feature/kitti2bag #1762

wants to merge 6 commits into from

Conversation

alexandrx
Copy link

Status

DEVELOPMENT

Description

Added the program kitti2bag tool, to convert KITTI dataset files into BAG files, into ros/src/util/packages/kitti_pkg as a submodule.
And extra option odom_velo was added to support creation of pointcloud only BAG files from the KITTI odometry/SLAM evaluation dataset (http://www.cvlibs.net/datasets/kitti/eval_odometry.php).

Related PRs

None

Todos

  • Tests
  • Documentation

Steps to Test or Reproduce

  1. Clone branch feature/kitti2bag and build Autoware the conventional way.
  2. Read the instructions and follow the example on ros/src/util/packages/kitti_pkg/kitti2bag/README.md
  3. To test the new option odom_velo make sure to download the Velodyne dataset for odometry evaluation (http://www.cvlibs.net/download.php?file=data_odometry_velodyne.zip).
    For better results (at least for sequences 11 and over) use pykitti from 'No 'FileNotFoundError' on Python2.x utiasSTARS/pykitti#39'.
    For any sequence number 'XX' (where XX=00,01,...,10 for training and XX=11,12,...,21 for evaluation) run the following command:
python kitti2bag -s XX odom_velo <VELODYNE-DATASET-FOLDER>

wherer VELODYNE-DATASET-FOLDER is the folder where all sequences are located, normally its name is dataset and includes at least one subfolder called sequences.

…opic names for cloud and imu, renamed some labels, changed default values of IP addresses
… extra options to rosbag play like `--topics` to select which topics to play, or `--duration` to indicate for how long we wish to play the bag file, and even topic remapping (ex., `/old_topic_name:=/new_topic_name`).
… makes sure the name of the intensity field is actually 'intensity'.
@alexandrx alexandrx requested a review from amc-nu December 4, 2018 09:37
@@ -458,6 +489,121 @@ params :
dash : ''
delim: ':='
must : true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be here

@@ -0,0 +1,93 @@
#!/usr/bin/env python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please change the license to Apache2?

import sys
import rosbag
import argparse
import progressbar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the python dependencies to package.xml

@@ -225,6 +225,37 @@ subs :
desc : Launches the driver for the selected RoboSense LiDAR sensor and publishes the pointcloud in rslidar_points.
run : roslaunch rslidar_pointcloud cloud_nodelet_16.launch

- name : Ouster OS1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please merge develop branch ? to fix this and the submodules conflict

@gbiggs
Copy link

gbiggs commented Mar 18, 2019

The content of this PR are not entirely covered by the PR's title or description. The sub-module part is no longer valid given the repository reorganisation. Please file a new PR from a fork for any of the other changes you want to keep.

@gbiggs gbiggs closed this Mar 18, 2019
@gbiggs gbiggs deleted the feature/kitti2bag branch May 29, 2020 07:42
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants