perf: svg loading improvements (#3470)

avo-hq · Nov 28, 2024 · 2b46f8f · 2b46f8f
1 parent 0701eff
commit 2b46f8f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/app/helpers/avo/application_helper.rb b/app/helpers/avo/application_helper.rb
@@ -65,7 +65,7 @@ def svg(file_name, **args)
 
       file_name = "#{file_name}.svg" unless file_name.end_with? ".svg"
 
-      with_asset_finder(::Avo::SvgFinder) do
+      Avo::CACHED_SVGS[file_name] ||= with_asset_finder(::Avo::SvgFinder) do
         inline_svg file_name, **args
       end
     end

diff --git a/lib/avo.rb b/lib/avo.rb
@@ -19,6 +19,7 @@ module Avo
   COOKIES_KEY = "avo"
   MODAL_FRAME_ID = :modal_frame
   ACTIONS_BACKGROUND_FRAME = :actions_background
+  CACHED_SVGS = {}
 
   class LicenseVerificationTemperedError < StandardError; end