fix: radio field (#3437)

* fix: radio field * code climate * fix double radio issue by setting the field_name_attribute on the pluggy field * Plugin manager register `field_name_attribute` --------- Co-authored-by: Paul Bob <[email protected]>
avo-hq · Nov 18, 2024 · 9a7a75e · 9a7a75e
1 parent 9d85d0f
commit 9a7a75e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/app/avo/fields/radio_field.rb → lib/avo/fields/radio_field.rb b/app/avo/fields/radio_field.rb → lib/avo/fields/radio_field.rb
diff --git a/lib/avo/plugin_manager.rb b/lib/avo/plugin_manager.rb
@@ -13,6 +13,12 @@ def register(name, priority: 10)
     end
 
     def register_field(method_name, klass)
+      # Avo.boot method is executed multiple times.
+      # During the first run, it correctly loads descendants of Avo::Fields::Base.
+      # Plugins are then loaded, introducing additional descendants to Avo::Fields::Base.
+      # On subsequent runs, Avo::Fields::Base descendants now include these plugin fields.
+      # This field_name_attribute assign forces the field name to retain the registered name instead of being computed dynamically from the field class.
+      klass.field_name_attribute = method_name
       Avo.field_manager.load_field method_name, klass
     end
 

diff --git a/spec/features/avo/radio_field_spec.rb b/spec/features/avo/radio_field_spec.rb
@@ -25,6 +25,11 @@
       it "changes the fish size" do
         visit "/admin/resources/fish/#{fish.id}/edit"
 
+        expect(Avo.field_manager.fields).to include(
+          {name: "radio", class: Avo::Fields::RadioField},
+          {name: "pluggy_radio", class: Pluggy::Fields::RadioField}
+        )
+
         expect(page).to have_checked_field "fish_size_small"
         expect(page).to_not have_checked_field "fish_size_medium"
         expect(page).to_not have_checked_field "fish_size_large"