refactor: rename implicit_authorization to explicit_authorization (…

…#3356)
avo-hq · Oct 23, 2024 · a3f9c69 · a3f9c69
1 parent ba99622
commit a3f9c69
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/app/controllers/avo/associations_controller.rb b/app/controllers/avo/associations_controller.rb
@@ -154,7 +154,7 @@ def authorize_if_defined(method, record = @record)
 
       if @authorization.has_method?(method.to_sym)
         @authorization.authorize_action method.to_sym
-      elsif !@authorization.is_a?(Avo::Services::AuthorizationService) && Avo.configuration.implicit_authorization
+      elsif !@authorization.is_a?(Avo::Services::AuthorizationService) && Avo.configuration.explicit_authorization
         raise Avo::NotAuthorizedError.new
       end
     end

diff --git a/lib/avo/concerns/checks_assoc_authorization.rb b/lib/avo/concerns/checks_assoc_authorization.rb
@@ -35,7 +35,7 @@ def authorize_association_for(policy_method)
         if service.has_method?(method_name, raise_exception: false)
           service.authorize_action(method_name, record:, raise_exception: false)
         elsif !service.is_a?(Avo::Services::AuthorizationService)
-          !Avo.configuration.implicit_authorization
+          !Avo.configuration.explicit_authorization
         else
           true
         end

diff --git a/lib/avo/configuration.rb b/lib/avo/configuration.rb
@@ -9,7 +9,7 @@ class Configuration
     attr_writer :logger
     attr_writer :turbo
     attr_writer :pagination
-    attr_writer :implicit_authorization
+    attr_writer :explicit_authorization
     attr_accessor :timezone
     attr_accessor :per_page
     attr_accessor :per_page_steps
@@ -70,7 +70,7 @@ def initialize
       @license_key = nil
       @current_user = proc {}
       @authenticate = proc {}
-      @implicit_authorization = false
+      @explicit_authorization = false
       @authorization_methods = {
         index: "index?",
         show: "show?",
@@ -259,8 +259,8 @@ def default_locale
       @locale || I18n.default_locale
     end
 
-    def implicit_authorization
-      Avo::ExecutionContext.new(target: @implicit_authorization).handle
+    def explicit_authorization
+      Avo::ExecutionContext.new(target: @explicit_authorization).handle
     end
   end
 

diff --git a/lib/avo/fields/has_base_field.rb b/lib/avo/fields/has_base_field.rb
@@ -100,7 +100,7 @@ def authorized?
         if service.has_method? method
           service.authorize_action(method, raise_exception: false)
         elsif !service.is_a?(Avo::Services::AuthorizationService)
-          !Avo.configuration.implicit_authorization
+          !Avo.configuration.explicit_authorization
         else
           true
         end

diff --git a/lib/generators/avo/templates/initializer/avo.tt b/lib/generators/avo/templates/initializer/avo.tt
@@ -41,7 +41,7 @@ Avo.configure do |config|
   # }
   # config.raise_error_on_missing_policy = false
   config.authorization_client = nil
-  config.implicit_authorization = true
+  config.explicit_authorization = true
 
   ## == Localization ==
   # config.locale = 'en-US'

diff --git a/spec/dummy/config/initializers/avo.rb b/spec/dummy/config/initializers/avo.rb
@@ -33,7 +33,7 @@
   # config.raise_error_on_missing_policy = true
   # config.authorization_client = "Avo::Services::AuthorizationClients::ExtraPunditClient"
   # Shouldn't impact on community only if custom authorization service was configured.
-  config.implicit_authorization = true
+  config.explicit_authorization = true
 
   ## == Customization ==
   config.id_links_to_resource = true