Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image uploads to the EasyMDE editor #3611

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erozas
Copy link

@erozas erozas commented Jan 27, 2025

Description

This PR adds the ability to upload images from the Easy MDE markdown editor.

If the image_upload boolean attribute is present when configuring the field, it will add an icon that can trigger image uploads and the ability to drag and drop files into the editor.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

The feature flow looks like this:

avo-easy-mde-uploads.mp4

Manual review steps

  1. Run the Avo test application.
  2. Navigate to the projects page.
  3. Click on the edit icon for the last project or any project whatsoever.
  4. On the project page, focus on the Easy MDE editor and go to an empty line or make an empty line.
  5. Click on the second image icon, which will render a system file upload flow.
  6. Choose an image file (JPG, PNG, WEBP, etc.).
  7. The file should upload and be inserted into the markdown text.

Copy link

codeclimate bot commented Jan 27, 2025

Code Climate has analyzed commit 2120913 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant