Skip to content

Commit

Permalink
bump up the upload-download artifact action to v4 (#1012)
Browse files Browse the repository at this point in the history
*Issue #, if available:*
The `upload-artifacts` and the `download-artifacts` v3 are deprecated
and causing the workflows to be stopped.
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
srprash authored Feb 4, 2025
1 parent 3645a8a commit 2740c56
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/application-signals-e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
role-to-assume: arn:aws:iam::${{ secrets.APPLICATION_SIGNALS_E2E_TEST_ACCOUNT_ID }}:role/${{ secrets.APPLICATION_SIGNALS_E2E_TEST_ROLE_NAME }}
aws-region: us-east-1

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: aws-opentelemetry-agent.jar

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ jobs:
snapshot-ecr-role: ${{ secrets.JAVA_INSTRUMENTATION_SNAPSHOT_ECR }}

- name: Upload to GitHub Actions
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: aws-opentelemetry-agent.jar
path: otelagent/build/libs/aws-opentelemetry-agent-*.jar
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-upstream-snapshot-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
snapshot-ecr-role: ${{ secrets.JAVA_INSTRUMENTATION_SNAPSHOT_ECR }}

- name: Upload to GitHub Actions
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: aws-opentelemetry-agent.jar
path: otelagent/build/libs/aws-opentelemetry-agent-*.jar
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release-lambda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
./build-layer.sh
- name: Upload layer
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: aws-opentelemetry-java-layer.zip
path: lambda-layer/build/distributions/aws-opentelemetry-java-layer.zip
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
echo BUCKET_NAME=java-lambda-layer-${{ github.run_id }}-${{ matrix.aws_region }} | tee --append $GITHUB_ENV
- name: download layer.zip
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: aws-opentelemetry-java-layer.zip

Expand Down Expand Up @@ -138,7 +138,7 @@ jobs:
- name: upload layer arn artifact
if: ${{ success() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.LAYER_NAME }}
path: ${{ env.LAYER_NAME }}/${{ matrix.aws_region }}
Expand All @@ -158,7 +158,7 @@ jobs:
- uses: hashicorp/setup-terraform@v2

- name: download layerARNs
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ env.LAYER_NAME }}
path: ${{ env.LAYER_NAME }}
Expand Down Expand Up @@ -201,7 +201,7 @@ jobs:
cat layer.tf
- name: upload layer tf file
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: layer.tf
path: layer.tf
Expand Down

0 comments on commit 2740c56

Please sign in to comment.