-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): garbage collect ecr assets (under --unstable flag) #31841
base: main
Are you sure you want to change the base?
Conversation
@@ -12,11 +12,47 @@ import { ActiveAssetCache, BackgroundStackRefresh, refreshStacks } from './stack | |||
// eslint-disable-next-line @typescript-eslint/no-require-imports | |||
const pLimit: typeof import('p-limit') = require('p-limit'); | |||
|
|||
const ISOLATED_TAG = 'aws-cdk:isolated'; | |||
const ISOLATED_TAG = 'aws-cdk.isolated'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work for ECR tags because they don't like :
in the tag. It's a bit of a break as in it invalidates previous tags in s3, but I don't think that's a big deal at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Follow up to #31611 which introduced S3 Asset Garbage Collection
ECR Asset Garbage Collection
cdk gc
now collects ECR assets.or
all other options are duplicated from s3.
TODO:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license