Improve Client Registration Error Collection #4993
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...community/src/software/aws/toolkits/jetbrains/core/credentials/sso/SsoAccessTokenProvider.kt
Fixed
Show fixed
Hide fixed
...community/src/software/aws/toolkits/jetbrains/core/credentials/sso/SsoAccessTokenProvider.kt
Fixed
Show fixed
Hide fixed
…json & stored in cache
samgst-amazon
force-pushed
the
samgst/AddClientRegistrationErrorMetrics
branch
from
1498d93
to
e723169
Compare
samgst-amazon
commented
Oct 21, 2024
| if (registration == null) { | ||
| val message = "Unable to load client registration from cache" | ||
| val (message, reason) = when { | ||
| currentToken.expiresAt.isBefore(Instant.now(clock)) -> Pair( |
There was a problem hiding this comment.
may need to change this whole block but I still need to add reauth logic here!
samgst-amazon
force-pushed
the
samgst/AddClientRegistrationErrorMetrics
branch
from
e723169
to
a93e410
Compare
samgst-amazon
force-pushed
the
samgst/AddClientRegistrationErrorMetrics
branch
from
a93e410
to
7504455
Compare
rli
reviewed
Oct 22, 2024
Comment on lines
+516
to
+518
| } catch (e: Exception) { | ||
| throw e | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Error loading client registration - Error collection
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.