Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(clients): regen qdev streaming client (IGNORE) #6335

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Jan 10, 2025

Problem

Build instructions are outdated and don't appear to work. This PR is an attempt to update them and regenerate the clients.

Solution

Notes

  • Currently the new clients use older dependencies than the ones committed, which is strange? Suspect this is built from the wrong package.
  • New clients avoid depending on @smithy/* packages directly and prefer @aws-sdk/*.

--

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Hweinstock Hweinstock force-pushed the regenClients branch 3 times, most recently from afbd917 to 1bb2f6f Compare January 10, 2025 19:18
return {
apiVersion: "2024-06-11",
base64Decoder: config?.base64Decoder ?? fromBase64,
export const getRuntimeConfig = (config: QDeveloperStreamingClientConfig) => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this needs to be explicitly typed, based on this LLM comment:

If you're exporting the function in runtimeConfig.shared.ts, add a return type there:

In runtimeConfig.shared.ts:

import { RuntimeConfig } from "@aws-sdk/types";

export const getRuntimeConfig = (): RuntimeConfig => {
  // Your implementation here
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think @aws-sdk/types exports this type for us unfortunately. Also, hoping to avoid manually adjusting generated code. One of the goals is to have these clients be generated as a build step or at least in an easily automatable fashion, so any manual touching of the generated files will be overwritten.

@Hweinstock Hweinstock changed the title deps(clients): regen streaming clients (IGNORE) deps(clients): regen qdev streaming client (IGNORE) Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants