-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(clients): regen qdev streaming client (IGNORE) #6335
base: master
Are you sure you want to change the base?
Conversation
|
afbd917
to
1bb2f6f
Compare
return { | ||
apiVersion: "2024-06-11", | ||
base64Decoder: config?.base64Decoder ?? fromBase64, | ||
export const getRuntimeConfig = (config: QDeveloperStreamingClientConfig) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this needs to be explicitly typed, based on this LLM comment:
If you're exporting the function in runtimeConfig.shared.ts, add a return type there:
In runtimeConfig.shared.ts:
import { RuntimeConfig } from "@aws-sdk/types";
export const getRuntimeConfig = (): RuntimeConfig => {
// Your implementation here
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think @aws-sdk/types
exports this type for us unfortunately. Also, hoping to avoid manually adjusting generated code. One of the goals is to have these clients be generated as a build step or at least in an easily automatable fashion, so any manual touching of the generated files will be overwritten.
Problem
Build instructions are outdated and don't appear to work. This PR is an attempt to update them and regenerate the clients.
Solution
Notes
@smithy/*
packages directly and prefer@aws-sdk/*
.--
feature/x
branches will not be squash-merged at release time.