Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(amazonq): conditionally include classifier fields in telemetry #6352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dingfeli
Copy link

telemetry(amazonq): conditionally include classifierResult and classifierThreshold in pojo emitted in telemetry

Problem

Some fields in the POJO emitted in the telemetry were causing parsing errors when values are undefined.
These fields are the following:

  • classifierResult
  • classifierThreshold

Solution

This change aims to conditionally include the aforementioned fields based on whether or not their values undefined.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dingfeli dingfeli requested a review from a team as a code owner January 13, 2025 22:54
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@dingfeli dingfeli changed the title Conditionally include classifier fields in telemetry telemetry(amazonq): conditionally include classifier fields in telemetry Jan 13, 2025
@zixlin7
Copy link
Contributor

zixlin7 commented Jan 13, 2025

/retryBuilds

@dingfeli
Copy link
Author

PR lint check seems to be stuck on the old PR title. The test is failing even after I had changed the PR title.

@Hweinstock
Copy link
Contributor

PR lint check seems to be stuck on the old PR title. The test is failing even after I had changed the PR title.

You can get around this by closing and reopening the PR.

Invalid pull request title: `Conditionally include classifier fields in telemetry`

* Problem: missing colon (:) char
* Expected format: `type(scope): subject...`
    * type: one of (build, ci, config, deps, docs, feat, fix, perf, refactor, revert, style, telemetry, test, types)
    * scope: lowercase, <30 chars
    * subject: must be <[10](https://github.com/aws/aws-toolkit-vscode/actions/runs/12773919571/job/35606904836?pr=6362#step:5:11)0 chars
    * documentation: https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#pull-request-title
* Hint: *close and re-open the PR* to re-trigger CI (after fixing the PR title).

@justinmk3 justinmk3 closed this Jan 23, 2025
@justinmk3 justinmk3 reopened this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants