Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amazonq): Allow including binary files when execution is enabled #6430

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix(amazonq): Allow including binary files when execution is enabled #6430

merged 2 commits into from
Jan 27, 2025
+67 −37

Conversation

osdemah
Copy link
Member

@osdemah osdemah commented Jan 24, 2025

Problem

  • Fixes for execution engine

Solution

  • Don't drop binary files matching with extra gitignore rules
  • Don't drop .gitignore file from repository.

@osdemah osdemah requested review from a team as code owners January 24, 2025 19:18
@osdemah osdemah changed the title Allow including binary files when execution is enabled fix(/dev): Allow including binary files when execution is enabled Jan 24, 2025
@osdemah osdemah closed this Jan 24, 2025
@osdemah osdemah reopened this Jan 24, 2025
@github-actions GitHub Actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@osdemah osdemah changed the title fix(/dev): Allow including binary files when execution is enabled fix(amazonq): Allow including binary files when execution is enabled Jan 24, 2025
@osdemah osdemah closed this Jan 24, 2025
@osdemah osdemah reopened this Jan 24, 2025
justinmk3
justinmk3 reviewed Jan 27, 2025
View reviewed changes
packages/core/src/shared/utilities/workspaceUtils.ts
return `{${allPatterns.join(',')}}`
}

/**
* @param rootPath root folder to look for .gitignore files
* @param addExtraPatterns whether to add extra exclude patterns even if not in gitignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated

justinmk3
justinmk3 reviewed Jan 27, 2025
View reviewed changes
packages/core/src/shared/utilities/workspaceUtils.ts
@@ -313,13 +318,15 @@ async function filterOutGitignoredFiles(rootPath: string, files: vscode.Uri[]):
* @param sourcePaths the paths where collection starts
* @param workspaceFolders the current workspace folders opened
* @param respectGitIgnore whether to respect gitignore file
* @param addExtraIgnorePatterns whether to add extra exclude patterns even if not in gitignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated

@justinmk3 justinmk3 merged commit 8fd89a3 into aws:feature/q-dev-execution Jan 27, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk3 justinmk3 justinmk3 left review comments

@neilk-aws neilk-aws neilk-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osdemah @justinmk3 @neilk-aws