Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-cloudwatch-metrics] Add imagePullSecrets to the Helm Chart #909

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

krlydm
Copy link

@krlydm krlydm commented Feb 24, 2023

Issue

This is not an issue, it is an improvement.

Description of changes

Added imagePullSecrets to the daemonset to use if you need a secret to authenticate with a container repository.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

This change was deployed to an EKS cluster using the chart locally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krlydm krlydm changed the title Add imagePullSecrets to the Helm Chart [aws-cloudwatch-metrics] Add imagePullSecrets to the Helm Chart Feb 24, 2023
@krlydm
Copy link
Author

krlydm commented Mar 2, 2023

@bwagner5 @kishorj Let me know if you need anything else for this.

@krlydm
Copy link
Author

krlydm commented Mar 29, 2023

@bwagner5 @kishorj Apologize for pinging you on this again, but it would be great if we can somehow make progress on this request. Solving this is important for us to be able to access the docker images through our private docker registry which is configured to cache images from the dockerhub.

@krlydm
Copy link
Author

krlydm commented May 30, 2023

@bwagner5 @kishorj Let me know if you need anything else on this.

Merge from upstream master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants