Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse existing (Cluster)Issuer for webhooks certificate #974

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Pionerd
Copy link

@Pionerd Pionerd commented Jul 20, 2023

Issue

N/A

Description of changes

Instead of always creating a self-signed Issuer when opting to use cert-manager for the web hooks certificate, I would like to add the possibility to reuse an existing (Cluster)Issuer.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

Verified helm templating with different options
Deployed locally and tested the different options (with/without certmanager, with/without own Issuer)

Remark: the existing enableCertmanager value is changed to certManager.enabled (since other options are added as well). Don't know if you guys expect a patch or minor upgrade of the helm chart for this one.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Pionerd Pionerd requested review from kishorj and M00nF1sh as code owners July 20, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant