Reuse existing (Cluster)Issuer for webhooks certificate #974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description of changes
Instead of always creating a self-signed Issuer when opting to use cert-manager for the web hooks certificate, I would like to add the possibility to reuse an existing (Cluster)Issuer.
Checklist
README.md
for modified charts)version
inChart.yaml
for the modified chart(s)Testing
Verified helm templating with different options
Deployed locally and tested the different options (with/without certmanager, with/without own Issuer)
Remark: the existing enableCertmanager value is changed to certManager.enabled (since other options are added as well). Don't know if you guys expect a patch or minor upgrade of the helm chart for this one.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.