-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data quality automatic dashboard #4785
base: master
Are you sure you want to change the base?
Data quality automatic dashboard #4785
Conversation
import json | ||
|
||
|
||
class Variable: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use a better name instead of Variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll call it DashboardVariable, DashboardWidget, DashboardWidgetProperty to keep consistency.
logger.error(message) | ||
raise ValueError(message) | ||
|
||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a try except expression here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need it since if the dashboard exists we don't want to overwrite it.
Approved workflow |
…eate_monitoring_schedule with error handling, TODO: modify update_monitoring_schedule accordingly and add unit tests
…_data_quality_dashboard()
…nstead of endpoint name, the user provides an EndpointInput object
…to update_monitoring_schedule
…to update_monitoring_schedule methods for Data Quality and Model Quality
…oards are published using boto3
… so that only features from the specific monitoring schedule and endpoint are loaded
… modify test_dashboard_methods to take into account the new filters in the dashboard variables
e7286e6
to
827427a
Compare
Issue #, if available:
Description of changes: Add a new automatic dashboard generation parameter to the DefaultModelMonitor and ModelQualityMonitor. Automatically generate dashboards for data quality model monitoring jobs and model quality monitoring jobs.
Testing done: Unit tests verify that the dashboard is generated correctly and all error-handling in dashboard parameters are handled correctly via a Mock Boto3 client. The integration tests verify that dashboard publishing on Cloudwatch is successful with the real Boto3 client.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.