fix: Enable quantization and compilation in the same optimization job via ModelBuilder and add validations to prevent compilation for Llama-3.1 on TRTLLM. #4875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ModelBuilder.
Issue #, if available:
Description of changes: TRTLLM containers allow compilation and quantization at the same time, so the validations to ensure mutual exclusivity must be removed. Compilation using Llama-3.1 on TRTLLM v11 also doesn't currently work, so adding validations to prevent those jobs from being created.
Testing done: New and updated unit tests on jumpstart_builder and model_builder. Locally tested TRTLLM/Llama-3.1 validations from both JS and HF flow.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.