Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: remove legacy schema validation code (#3257)" #3258

Closed
wants to merge 1 commit into from
Closed

Revert "chore: remove legacy schema validation code (#3257)" #3258

wants to merge 1 commit into from

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Jul 14, 2023

Issue #, if available

Description of changes

This reverts commit 6a16639.

Noticed SamTemplateValidator is used in SAM CLI: https://github.com/aws/aws-sam-cli/blob/84184943aeec2423f1071a88297f7722edf6cbf2/samcli/lib/samlib/wrapper.py#L160

While it doesn't strictly break anything (the function calls still exist), creating this PR as heads-up to better determine whether the validation is desired, but can likely be closed again.

The reverted uses hand-written schemas to perform partial template validation; I'm not sure what the value is compared to just doing the transform.

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa closed this Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant