Revert "chore: remove legacy schema validation code (#3257)" #3258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
This reverts commit 6a16639.
Noticed
SamTemplateValidator
is used in SAM CLI: https://github.com/aws/aws-sam-cli/blob/84184943aeec2423f1071a88297f7722edf6cbf2/samcli/lib/samlib/wrapper.py#L160While it doesn't strictly break anything (the function calls still exist), creating this PR as heads-up to better determine whether the validation is desired, but can likely be closed again.
The reverted uses hand-written schemas to perform partial template validation; I'm not sure what the value is compared to just doing the transform.
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam init
through aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.