fix: Request Parameters not picked up for v1 payload format with mult…

…ivalue headers enabled (#1256)
aws · Feb 4, 2025 · f37fa4e · f37fa4e
1 parent 695dd06
commit f37fa4e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/...ot3/src/main/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtils.java b/...ot3/src/main/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtils.java
@@ -120,7 +120,7 @@ private static HttpServletRequest generateRequest1(String request, Context lambd
 		if (v1Request.getMultiValueQueryStringParameters() != null) {
 			MultiValueMapAdapter<String, String> queryStringParameters = new MultiValueMapAdapter(v1Request.getMultiValueQueryStringParameters());
 			queryStringParameters.forEach((k, v) -> {
-                httpRequest.setParameter(k, v.toArray(new String[2]));
+                httpRequest.setParameter(k, v.toArray(new String[0]));
             });
 		}
 

diff --git a/...rc/test/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtilsTests.java b/...rc/test/java/com/amazonaws/serverless/proxy/spring/AwsSpringHttpProcessingUtilsTests.java
@@ -233,7 +233,7 @@ private static void assertRequest(HttpServletRequest request) {
 		assertEquals("/async", request.getRequestURI());
 		assertNotNull(request.getServletContext());
 		// parameter handling for 2.0 requests is currently not spec compliant and to be fixed in future version
-		// see also GitHub issue
+		// see also GitHub issue https://github.com/aws/serverless-java-container/issues/1278
 		if (!(request.getAttribute(RequestReader.HTTP_API_EVENT_PROPERTY) instanceof HttpApiV2ProxyRequest)) {
 			assertEquals("value1", request.getParameter("parameter1"));
 			assertArrayEquals(new String[]{"value1", "value2"}, request.getParameterValues("parameter1"));

diff --git a/...va/com/amazonaws/serverless/proxy/spring/SpringDelegatingLambdaContainerHandlerTests.java b/...va/com/amazonaws/serverless/proxy/spring/SpringDelegatingLambdaContainerHandlerTests.java
@@ -215,10 +215,10 @@ public void validateComplesrequest(String jsonEvent) throws Exception {
         handler.handleRequest(targetStream, output, null);
         Map result = mapper.readValue(output.toString(StandardCharsets.UTF_8), Map.class);
         assertEquals(200, result.get("statusCode"));
-        String[] respponseBody = ((String) result.get("body")).split("/");
-        assertEquals("male", respponseBody[0]);
-        assertEquals("24", respponseBody[1]);
-        assertEquals("Ricky", respponseBody[2]);
+        String[] responseBody = ((String) result.get("body")).split("/");
+        assertEquals("male", responseBody[0]);
+        assertEquals("24", responseBody[1]);
+        assertEquals("Ricky", responseBody[2]);
     }
 
     @MethodSource("data")