115 allow multiple labels for one idea

[gerardo-navarro]

Closes #115

[gerardo-navarro]

@JannikStreek I know it is quite a big pull request. You can concentrate on checking out the latest version and doing some manual testing.

[JannikStreek]

@JannikStreek I know it is quite a big pull request. You can concentrate on checking out the latest version and doing some manual testing.

looks good to me. nice. the only thing I noticed: The order of labels is a bit unexpected. the first 4 labels always appear at the same position, meaning: If I add many new labels and add a label which was existing from the beginning, it will appear on position 1. For custom added labels, these will always appear at the end (which feels more naturally). So apparently the initial labels have a dedicated ordering slot while the newer ones are dynamically added at the end? I would propose to change the behavior of the initial labels also added to the end of the label list. But that's just a small thing I noticed.

[JannikStreek]

another minor issue: The Tooltip for label is not capitalized in the German version, maybe the translation is missing? So: label => Label / Bezeichnung / Tag

[JannikStreek]

have you tested the migration script with some existing brainstormings from the older version? Might be important to check if it works as expected.

[gerardo-navarro]

have you tested the migration script with some existing brainstormings from the older version? Might be important to check if it works as expected.

Thanks for the advice. I tested it. There is also an automated test for this migration.

[gerardo-navarro]

@JannikStreek I know it is quite a big pull request. You can concentrate on checking out the latest version and doing some manual testing.

looks good to me. nice. the only thing I noticed: The order of labels is a bit unexpected. the first 4 labels always appear at the same position, meaning: If I add many new labels and add a label which was existing from the beginning, it will appear on position 1. For custom added labels, these will always appear at the end (which feels more naturally). So apparently the initial labels have a dedicated ordering slot while the newer ones are dynamically added at the end? I would propose to change the behavior of the initial labels also added to the end of the label list. But that's just a small thing I noticed.

Thanks for the review and trying out the new feature.

Yes, you are right there is a small problem with the sorting. It will be tackled in #127 .