adds tests and read ttl functionality #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANorwell
approved these changes
Dec 2, 2016
dattocgernon
reviewed
Dec 5, 2016
| @client.insert(:test, item) | ||
|
|
||
| resulting_ttl = @client.select_ttl(:test, :d, {:id => 'i'}) | ||
| assert (1..ttl).include? resulting_ttl |
There was a problem hiding this comment.
Why the include? in this test instead of just an assert_equal ttl, resulting_ttl?
There was a problem hiding this comment.
depending on how long the query takes to execute the TTL could be less than it originally was
| @@ -161,6 +161,25 @@ def string_keys(hash) | |||
| end | |||
| end | |||
|
|
|||
| context 'select_ttl' do | |||
There was a problem hiding this comment.
Would be good to see one more test with two where_arguments (one integer and one string) just to fully exercise that select_ttl_statement method ...
There was a problem hiding this comment.
yeah good idea i can do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to read the TTL off of a cell by passing in the table_name, target column, and key value pairs for the where query