Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic frame delay based on maxClientFrameRate in IPVideoRoute #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

noio
Copy link

@noio noio commented Aug 31, 2017

In regards to:

TODO: smarter ways of doing for rate / fps limiting

The code in this PR updates the way the handleRequest thread sleeps to attempt to keep a steady fps with shorter waits for an empty queue.

I looked at the vars in IPVideoConnection and tried to guess at what the original design was, but saw that a few of them aren't being used anyway.

With this code I get smoother streaming with less delay. For many frames, the sending takes more time than 1000 / FPS ms, so the wait() is skipped entirely; this in contrast to the old code that always waits 30ms.

@noio noio changed the title Dynamic Frame Delay depending on Client Max Frame Rate in IPVideoRoute Dynamic frame delay based on maxClientFrameRate in IPVideoRoute Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant