fix download cancel (SMB)

barnabwhy · May 25, 2023 · e0a67b4 · e0a67b4
1 parent d52c2b9
commit e0a67b4
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/app/src/main/java/com/barnabwhy/picozen/Sideload/Providers/SMBProvider.java b/app/src/main/java/com/barnabwhy/picozen/Sideload/Providers/SMBProvider.java
@@ -22,20 +22,18 @@
 import com.hierynomus.smbj.session.Session;
 import com.hierynomus.smbj.share.DiskShare;
 
-import java.io.DataInputStream;
 import java.io.File;
 import java.io.FileOutputStream;
-import java.io.InputStream;
 import java.io.OutputStream;
 import java.nio.file.Files;
 import java.nio.file.Paths;
 import java.text.DateFormat;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
-import java.util.Date;
 import java.util.HashSet;
 import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Consumer;
 
 public class SMBProvider extends AbstractProvider {
@@ -223,17 +221,20 @@ protected static boolean saveFile(com.hierynomus.smbj.share.File file, File outp
         try {
             FileOutputStream fos = new FileOutputStream(outputFile);
 
+            AtomicBoolean didError = new AtomicBoolean(false);
             file.read(fos, (numBytes, totalBytes) -> {
                 if(outputFile.canWrite())
                     progressCallback.accept(totalBytes);
-                else
+                else {
                     file.close();
+                    didError.set(true);
+                }
             });
 
             fos.flush();
             fos.close();
 
-            return true;
+            return !didError.get();
         } catch (Exception e) {
             Log.e("Error", e.toString());
             return false;