Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update erc number #1943

Merged
merged 3 commits into from
Mar 7, 2025
Merged

update erc number #1943

merged 3 commits into from
Mar 7, 2025

Conversation

cb-jake
Copy link
Contributor

@cb-jake cb-jake commented Mar 7, 2025

What changed? Why?

Update the ERC number

Notes to reviewers

Smart wallet docs update

How has it been tested?

Manually

Copy link

vercel bot commented Mar 7, 2025

You must have Developer access to commit code to Coinbase on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 7, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Mar 7, 2025

@cb-jake is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-jake cb-jake marked this pull request as ready for review March 7, 2025 18:01
@cb-heimdall
Copy link
Collaborator

Review Error for montycheese @ 2025-03-07 18:05:36 UTC
User must have write permissions to review

@dschlabach dschlabach merged commit 1675024 into base:master Mar 7, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants