Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix code comments and variables errors #1951

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Conversation

intls
Copy link
Contributor

@intls intls commented Mar 8, 2025

What changed? Why?

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Mar 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2025 0:05am

Copy link

vercel bot commented Mar 8, 2025

@intls is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 8, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@intls
Copy link
Contributor Author

intls commented Mar 8, 2025

@dschlabach Hello! I've re-opened PR! Thanks!

@dschlabach dschlabach merged commit 168589c into base:master Mar 8, 2025
6 of 7 checks passed
@intls
Copy link
Contributor Author

intls commented Mar 8, 2025

@dschlabach Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants