Fix FR formatting #68
Conversation
| @@ -16,6 +16,12 @@ regex_definitions: | |||
| # Regular expression to match the prefixes that indicate a house number or name. | |||
| kHouseNumberOrNameOptionalPrefixRe: | |||
| regex_fragment: '(?:(?:no|nr|°|º|numéro)[-.\s]*)?' | |||
|
|
|||
| kCommaOrNewlineSeparator: | |||
There was a problem hiding this comment.
Isn't this similar to kCommaOrWhitespaceSeparator? I'm concerned about introducing multiple different separators on multiple country files. Ideally, we use shared ones as most as possible.
There was a problem hiding this comment.
French street names can have spaces in them, the kCommaOrWhitespaceSeparator ends up matching the first space and thus leading to the wrong parsing of the Place Charles de Gaulle
There was a problem hiding this comment.
I see. Then probably you want something like (?:, |\n|\r|,)+?
| - capture: | ||
| output: address-overflow | ||
| parts: [ {regex_fragment: '(?:[^,\r\n]+)'} ] | ||
| prefix: {regex_reference: kSpaceOptionalPrefixRe} |
There was a problem hiding this comment.
How about just inlining {regex_fragment: '\s*' }?
| @@ -16,6 +16,12 @@ regex_definitions: | |||
| # Regular expression to match the prefixes that indicate a house number or name. | |||
| kHouseNumberOrNameOptionalPrefixRe: | |||
| regex_fragment: '(?:(?:no|nr|°|º|numéro)[-.\s]*)?' | |||
|
|
|||
| kCommaOrNewlineSeparator: | |||
There was a problem hiding this comment.
I see. Then probably you want something like (?:, |\n|\r|,)+?
| output: | ||
| street-address-alternative-1: "Appt 1, 58 rue du Gue Jacquet" | ||
| street-address-alternative-1: "58 rue du Gue Jacquet, Appt 1" |
There was a problem hiding this comment.
Can you drop the space after the comma? I would like to validate that case as well.
This CL changes the formatting expression for address_overflow, making it go second after the building location