Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NL model #70

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Add NL model #70

merged 4 commits into from
Oct 24, 2024

Conversation

Pitchiu
Copy link
Collaborator

@Pitchiu Pitchiu commented Oct 23, 2024

This PR adds NL: model, metadata and descriptions.

@Pitchiu Pitchiu requested review from skyman503 and norgevz October 23, 2024 15:57
model/countries/NL/NL-metadata.yaml Outdated Show resolved Hide resolved
model/countries/NL/NL-metadata.yaml Outdated Show resolved Hide resolved
model/countries/NL/NL-descriptions.yaml Outdated Show resolved Hide resolved
model/countries/NL/NL-model.yaml Outdated Show resolved Hide resolved
model/countries/NL/NL-model.yaml Show resolved Hide resolved
@Pitchiu Pitchiu requested a review from norgevz October 24, 2024 10:13
@skyman503
Copy link
Collaborator

The model LGTM :)

Copy link
Collaborator

@norgevz norgevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one ask.

Well done!

model/countries/NL/NL-model.yaml Show resolved Hide resolved
@Pitchiu Pitchiu merged commit 98d5b53 into main Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants