Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] #2866

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[email protected] #2866

wants to merge 4 commits into from
+473 −10

Conversation

aaliddell
Copy link
Contributor

@aaliddell aaliddell mentioned this pull request Sep 30, 2024
Merged
@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Sep 30, 2024
Wyverald
Wyverald previously approved these changes Sep 30, 2024
View reviewed changes
@Wyverald Wyverald enabled auto-merge (squash) September 30, 2024 21:11
@Wyverald
Copy link
Member

Wyverald commented Oct 1, 2024

please fix the check failures.

auto-merge was automatically disabled October 3, 2024 22:36

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed Wyverald’s stale review October 3, 2024 22:36

Require module maintainers' approval for newly pushed changes.

@aaliddell
Copy link
Contributor Author

Fixed, I’d missed a commit cherry-pick. Those two remaining failures look like download rate limits and I can’t retry them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaliddell @Wyverald