Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add triton-inference-server-common. #2975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryanli
Copy link

@ryanli ryanli commented Oct 17, 2024

No description provided.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (triton-inference-server-common) have been updated in this PR. Please review the changes.

@ryanli ryanli force-pushed the main branch 2 times, most recently from 41bfcba to 1c11129 Compare October 17, 2024 09:11
@ryanli
Copy link
Author

ryanli commented Oct 17, 2024

The version 0.0.0-20240821-578491f seems to be causing problems but I see existing packages such as googleapis using this pattern. Please advise on how to proceed from here?

@meteorcloudy meteorcloudy added the skip-url-stability-check Skip the URL stability check for the PR label Oct 17, 2024
@meteorcloudy
Copy link
Member

It's not the version number, it's the source url is unstable: https://blog.bazel.build/2023/02/15/github-archive-checksum.html

I've added a label to bypass this check.

@meteorcloudy meteorcloudy enabled auto-merge (squash) October 17, 2024 09:36
meteorcloudy
meteorcloudy previously approved these changes Oct 17, 2024
auto-merge was automatically disabled October 17, 2024 10:00

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed meteorcloudy’s stale review October 17, 2024 10:00

Require module maintainers' approval for newly pushed changes.

@meteorcloudy
Copy link
Member

presubmit failing on debian11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants