Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #2996

Merged

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @keith, @BalestraPatrick, @brentleyjones, @thii, modules you maintain (rules_swift) have been updated in this PR. Please review the changes.

brentleyjones
brentleyjones previously approved these changes Oct 21, 2024
@brentleyjones brentleyjones enabled auto-merge (squash) October 21, 2024 21:29
@bazel-io bazel-io dismissed brentleyjones’s stale review October 21, 2024 21:38

Require module maintainers' approval for newly pushed changes.

brentleyjones
brentleyjones previously approved these changes Oct 21, 2024
@brentleyjones
Copy link
Contributor

@bazelbuild/bcr-maintainers Can I get a force merge on this? The failure is caused by the current released version of protobuf not supporting Bazel 8/HEAD. It's not a real failure.

bazel-io
bazel-io previously approved these changes Oct 21, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@fmeum fmeum disabled auto-merge October 21, 2024 21:56
fmeum
fmeum previously approved these changes Oct 21, 2024
modules/rules_swift/2.2.0/presubmit.yml Outdated Show resolved Hide resolved
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require module maintainers' approval.

@bazel-io bazel-io dismissed stale reviews from brentleyjones, fmeum, and themself October 22, 2024 12:53

Require module maintainers' approval for newly pushed changes.

@brentleyjones brentleyjones enabled auto-merge (squash) October 22, 2024 12:59
@brentleyjones brentleyjones merged commit db20163 into bazelbuild:main Oct 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants