-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty globs in some boost libraries #2997
base: main
Are you sure you want to change the base?
Conversation
This fixes support for `--incompatible_disallow_empty_glob` in some boost libraries.
Hello @wep21, @Vertexwahn, modules you maintain (boost.assert, boost.bind, boost.config, boost.container_hash, boost.core, boost.describe, boost.detail, boost.function, boost.function_types, boost.functional, boost.interprocess, boost.intrusive, boost.io, boost.move, boost.mp11, boost.mpl, boost.predef, boost.preprocessor, boost.static_assert, boost.throw_exception, boost.tuple, boost.type_traits, boost.typeof, boost.unordered, boost.utility, boost.winapi) have been updated in this PR. Please review the changes. |
@@ -0,0 +1,16 @@ | |||
matrix: | |||
platform: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the opportunity to extend the tested platforms:
platform:
- debian10
- debian11
- macos
- macos_arm64
- ubuntu2004
- ubuntu2204
- ubuntu2404
- windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a header-only lib, we could also make use of the --process_headers_in_dependencies
feature -> https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/boost.detail/1.83.0/presubmit.yml -> will restrict us to Bazel >=7.2.1
This fixes support for
--incompatible_disallow_empty_glob
in some boost libraries. This is a copy of the previous version, the only changes are removing the invalid glob (mostlyinclude/**/*.h
) and bumping the deps to the other.bcr.1
versions