Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcript: Adds view tracking #12251

Draft
wants to merge 1 commit into
base: WSTEAM1-TRANSCRIPT-SIGNPOST-CLONE
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/app/components/Transcript/index.test.tsx
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@ import React from 'react';
import { render } from '../react-testing-library-with-providers';
import transcriptFixture from './fixture.json';
import Transcript from './index';
import * as viewTracking from '../../hooks/useViewTracker';

describe('Transcript Component', () => {
it('should match snapshot (temp)', () => {
@@ -58,4 +59,16 @@ describe('Transcript Component', () => {
const details = container.querySelector('details');
expect(details).not.toBeInTheDocument();
});

describe('view tracking', () => {
const viewTrackerSpy = jest.spyOn(viewTracking, 'default');

it('should register view tracking', () => {
render(<Transcript transcript={transcriptFixture} title="My Title" />);

expect(viewTrackerSpy).toHaveBeenCalledWith({
componentName: 'Transcript',
});
});
});
});
4 changes: 3 additions & 1 deletion src/app/components/Transcript/index.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/** @jsx jsx */
/* eslint-disable jsx-a11y/aria-role */
import { jsx } from '@emotion/react';
import useViewTracker from '#app/hooks/useViewTracker';
import styles from './index.styles';
import Text from '../Text';
import TranscriptTimestamp from './TranscriptTimestamp';
@@ -28,6 +29,7 @@ const Transcript = ({
transcript: TranscriptBlock;
title?: string;
}) => {
const viewRef = useViewTracker({ componentName: 'Transcript' });
const transcriptItems = transcript?.model?.blocks;
if (!transcriptItems) {
return null;
@@ -47,7 +49,7 @@ const Transcript = ({
{title && <VisuallyHiddenText>{formattedTitle}</VisuallyHiddenText>}
</span>
</summary>
<ul css={styles.ul} role="list">
<ul css={styles.ul} role="list" ref={viewRef}>
{/* eslint-disable-next-line @typescript-eslint/no-unused-vars */}
{transcriptItems.map((item, _index) => (
<TranscriptListItem
Loading