Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to previous path as it is no longer required #12402

Draft
wants to merge 10 commits into
base: latest
Choose a base branch
from

Conversation

karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Feb 12, 2025

Overall changes

Deletes all references to previousPath as it was required for Single Page Application, which has now been removed (see #10849 and search for previousPath - it is no longer set, and is therefore always null).

This simplifies our analytics code, especially when getting the referrer (which is used for ATI and Chartbeat Analytics)

Code changes

  • Delete all references to previousPath
  • Delete many references to origin as it was required in conjunction with previousPath to construct the referrer
  • Tidy up tests

Testing

@karinathomasbbc karinathomasbbc self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant