WORLDSERVICE-37 - Delete FrontPage and all associated code [DNM] #12444

LilyL0u · 2025-02-25T12:39:49Z

Resolves JIRA https://jira.dev.bbc.co.uk/browse/WORLDSERVICE-37 and https://jira.dev.bbc.co.uk/browse/WORLDSERVICE-356

Overall changes

Removes FrontPage components and associated components that are no longer in use
Removes Tests and FrontPage specific fixture data

Notes

We will need to update frontPageRadioSchedule toggle to homePageRadioSchedule

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

LilyL0u · 2025-02-25T12:40:41Z

src/app/components/ATIAnalytics/params/index.test.ts

@@ -430,29 +383,18 @@ describe('ATIAnalytics params', () => {
          }),
        );
      });
-
-      it('should not invoke buildPageATIUrl for an unmigrated page type with no atiData', () => {


Do we need another page type to be used and keep this test? What is unmigrated that is suitable here, and do we even need this test anymore?

All page types have now been migrated. Ideally we would actually remove the support for ati + pageData (as it should now be coming from atiData), but that's a separate (and big!) piece of work - probably part of the Reverb migration work.

…ot used

…exts

… same data is not present in the home page pagedata in the same way

LilyL0u · 2025-02-25T20:46:55Z

src/app/routes/utils/regex/index.test.js

@@ -443,7 +425,7 @@ describe('legacyAssetPageDataPath', () => {
  shouldNotMatchInvalidRoutes(invalidDataRoutes, legacyAssetPageDataPath);
 });

-describe('frontPage -> homePage migration', () => {
+describe('homepage regex on environments', () => {


ukchina is included as a valid route for home page regex. We won't be merging this until the ukchina work is done.

We've paused the merging for now so this won't be merged in this sprint.

LilyL0u · 2025-02-25T23:25:26Z

src/server/local/index.js

-
-      sendDataFile(res, dataFilePath, next);
-    })
-    .get(homePageDataPath, async ({ params }, res, next) => {


We do not use the home page data route any more right? In constructDataFilePath it uses the path /index.json, which we don't use.

https://www.bbc.com/mundo/index.json this is not our 404 page

Confusingly, we serve the file named index.json within data/mundo/homePage as the local homepage data route http://localhost:7080/mundo.json 🤯

LilyL0u · 2025-02-25T23:57:02Z

src/server/index.test.jsx

@@ -1106,11 +1106,6 @@ describe('Server', () => {
    });

    describe('for home pages', () => {
-      it('should respond with JSON', async () => {


we don't use json routes with home pages now

We do on local though

I think the JSON routes are still used for the local fixture routes on dev

src/server/index.jsx

…t home page

src/app/components/ChartbeatAnalytics/utils/index.ts

src/app/routes/utils/regex/index.test.js

karinathomasbbc · 2025-03-03T14:23:02Z

src/server/local/index.js

-
-      sendDataFile(res, dataFilePath, next);
-    })
-    .get(homePageDataPath, async ({ params }, res, next) => {


Confusingly, we serve the file named index.json within data/mundo/homePage as the local homepage data route http://localhost:7080/mundo.json 🤯

karinathomasbbc · 2025-03-03T14:25:48Z

src/app/routes/utils/regex/index.test.js

+    // '/persian.json',
+    // '/serbian/cyr.json',
+    // '/ukchina/trad.json', // work out if we need these data routes still. They work locally but not live


Hmm it's a good question. I believe that they are now valid homepage routes, since we have removed the frontPage routing. Let's move these into another test for valid routes.

src/app/routes/utils/regex/utils/index.js

…ssociated-code

src/app/routes/utils/regex/index.test.js

…ssociated-code

pvaliani · 2025-03-04T15:57:01Z

Should some of the content for the frontPage Radio Schedule toggles not also be removed?

simorgh/src/app/components/Curation/index.tsx

Line 141 in bb57d19

toggleName="frontPageRadioSchedule"

pvaliani · 2025-03-04T16:01:00Z

This whole script and the releaseInfo folder it's within can maybe get deleted?

https://github.com/bbc/simorgh/blob/c664720334ae1b6177b5cb77d1435512dc96705b/scripts/releaseInfo/launchDates.js

Contains frontPage info but I don't think the script is in use other than here:

simorgh/.codeclimate.yml

Line 21 in b1369ce

- 'scripts/simorghLaunchDates.js'

@karinathomasbbc any thoughts?

pvaliani

Comments aside, looks pretty good!

amoore108 · 2025-03-04T16:08:46Z

Should some of the content for the frontPage Radio Schedule toggles not also be removed?

simorgh/src/app/components/Curation/index.tsx

Line 141 in bb57d19

toggleName="frontPageRadioSchedule"

This is a naming thing unfortunately. Think this is still technically used on homepages, just has word frontPage in it! We should probably migrate that toggle to a new name.

karinathomasbbc · 2025-03-04T16:17:34Z

This whole script and the releaseInfo folder it's within can maybe get deleted?

https://github.com/bbc/simorgh/blob/c664720334ae1b6177b5cb77d1435512dc96705b/scripts/releaseInfo/launchDates.js

Contains frontPage info but I don't think the script is in use other than here:

simorgh/.codeclimate.yml

Line 21 in b1369ce

- 'scripts/simorghLaunchDates.js'

@karinathomasbbc any thoughts?

Yes please. I created this script 5 years ago to generate the simorgh-release-info file & also to keep track of when we released things (as we were migrating off PAL). So this file / folder and all references can get in the 🗑️ 🔥 💣 💥

karinathomasbbc · 2025-03-04T16:19:26Z

Should some of the content for the frontPage Radio Schedule toggles not also be removed?

simorgh/src/app/components/Curation/index.tsx

Line 141 in bb57d19

toggleName="frontPageRadioSchedule"

This is a naming thing unfortunately. Think this is still technically used on homepages, just has word frontPage in it! We should probably migrate that toggle to a new name.

Could you rename all references in this PR, and with some careful timing, just update the toggle name in iSite when it's deployed? If I recall correctly, none of the services actually have the radio schedule on the front page at the moment, so I don't think they would be affected.

…ssociated-code

LilyL0u added 2 commits February 25, 2025 12:31

remove front page from ati chartbear and event tracking

f15d732

remove front page from tracking tests

e10fe1a

LilyL0u commented Feb 25, 2025

View reviewed changes

LilyL0u added 15 commits February 25, 2025 12:44

ad tests should use home page instead of front page

a028fc0

remove front page conditionals from image component

418500a

replace imageWithPlaceholder fixture data with Home page type

c4b7612

remove inclusion of front page for when psammead images are used or n…

924471b

…ot used

radio schedule tests now use home page not front page

59cba6b

radio schedule utilities now use home page not front page

193a796

remove front page from analyticsUtils indexPage

a6e8684

remove test for absence of most read on amp front page

01f28bf

unneeded getStatsPageIdentifier and front page used in tests for cont…

4f4dd17

…exts

change metadata tests to be for home page with hard coded data as the…

d48feef

… same data is not present in the home page pagedata in the same way

replace the use of front page in header tests for home page

9353b07

test consent banner a11y yesy with home page instead of front pagecd

aba9446

remove front page routes

75dcb41

delete FrontPage page folder

66e0f2a

remove front page from atianalytics params

8579af6

LilyL0u commented Feb 25, 2025

View reviewed changes

github-advanced-security bot found potential problems Feb 25, 2025

View reviewed changes

src/server/index.jsx Dismissed Show dismissed Hide dismissed

LilyL0u force-pushed the WORLDSERVICE-37-delete-frontpage-and-all-associated-code branch from 826a465 to 8579af6 Compare February 26, 2025 15:47

LilyL0u added 7 commits February 26, 2025 16:11

this made the home page actually load

40286bf

maybe these changes were unnecessary, removed them and can still visi…

21b4fdc

…t home page

fix server tests to be for home page not front page

a651a12

try to fix front page bundle size errors

5e55ea2

utils regex tests and code change but homePageDataPAth left in

2df457a

remove cypress front page references

b1c482c

remove front page import from pages mocks folder

a75f795

karinathomasbbc reviewed Mar 3, 2025

View reviewed changes

amoore108 added 7 commits March 3, 2025 16:19

Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…

b8669d3

…ssociated-code

Regex tidy

b85bd1e

Remove index from Chartbeat

0ee3ea5

Regex test revert

a5ba9ec

Delete commented out test routes

b8cc61f

Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…

ee3abfe

…ssociated-code

Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…

eec965e

…ssociated-code

pvaliani marked this pull request as ready for review March 4, 2025 10:33

pvaliani self-requested a review March 4, 2025 10:34

pvaliani assigned LilyL0u and amoore108 Mar 4, 2025

karinathomasbbc reviewed Mar 4, 2025

View reviewed changes

src/app/routes/utils/regex/index.test.js Show resolved Hide resolved

karinathomasbbc approved these changes Mar 4, 2025

View reviewed changes

amoore108 and others added 3 commits March 4, 2025 10:50

Update regex env test

8c6a08d

Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…

3b9af7c

…ssociated-code

Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…

e94fe83

…ssociated-code

pvaliani approved these changes Mar 4, 2025

View reviewed changes

pvaliani and others added 7 commits March 4, 2025 16:23

remove unused launchdates script

41d76fa

remove reference to launchdates.js in codeclimate yaml

86a94f7

Update frontPageRadioSchedule references to homePageRadioSchedule

ebd8575

Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…

9247663

…ssociated-code

Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…

2fb8a9a

…ssociated-code

Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…

47db144

…ssociated-code

Merge branch 'latest' into WORLDSERVICE-37-delete-frontpage-and-all-a…

842b93a

…ssociated-code

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WORLDSERVICE-37 - Delete FrontPage and all associated code [DNM] #12444

WORLDSERVICE-37 - Delete FrontPage and all associated code [DNM] #12444

LilyL0u commented Feb 25, 2025 •

edited by amoore108

Loading

LilyL0u Feb 25, 2025

karinathomasbbc Mar 3, 2025

LilyL0u Feb 25, 2025

pvaliani Mar 4, 2025

LilyL0u Feb 25, 2025

LilyL0u Feb 25, 2025

karinathomasbbc Mar 3, 2025

LilyL0u Feb 25, 2025

karinathomasbbc Mar 4, 2025

pvaliani Mar 4, 2025

karinathomasbbc Mar 3, 2025

karinathomasbbc Mar 3, 2025

pvaliani commented Mar 4, 2025

pvaliani commented Mar 4, 2025

pvaliani left a comment

amoore108 commented Mar 4, 2025

karinathomasbbc commented Mar 4, 2025

karinathomasbbc commented Mar 4, 2025

WORLDSERVICE-37 - Delete FrontPage and all associated code [DNM] #12444

Are you sure you want to change the base?

WORLDSERVICE-37 - Delete FrontPage and all associated code [DNM] #12444

Conversation

LilyL0u commented Feb 25, 2025 • edited by amoore108 Loading

Overall changes

Notes

Helpful Links

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pvaliani commented Mar 4, 2025

pvaliani commented Mar 4, 2025

pvaliani left a comment

Choose a reason for hiding this comment

amoore108 commented Mar 4, 2025

karinathomasbbc commented Mar 4, 2025

karinathomasbbc commented Mar 4, 2025

LilyL0u commented Feb 25, 2025 •

edited by amoore108

Loading