Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a empty alias for noContent #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Taluu
Copy link

@Taluu Taluu commented Dec 27, 2018

I'm not sure how to deprecate things, but I "deprecated" noContent and transformed it into an alias for the new empty assertion.

Fixes #249

@rquadling
Copy link
Contributor

I'd leave out the @deprecated for the time being. Deprecating an assertion can cause end users a real nightmare if there is not a clear path an a LOT of notice.

@Taluu
Copy link
Author

Taluu commented Dec 28, 2018

I removed the @deprecated. I thought that the given message (using empty instead) would do the trick, unless you'd like to add a trigger_error with it ? Not sure what would be a better deprecation path though...

@Taluu
Copy link
Author

Taluu commented Feb 5, 2020

Rebased and updated from upstream/master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename noContent to isEmpty? Or at least alias it?
2 participants