Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change missing plugin to allow for filtering albums by release type #5587

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bgrassy
Copy link

@bgrassy bgrassy commented Jan 11, 2025

Description

Addresses #2661.

Currently, the missing plugin when ran in album mode only allows for getting all release groups attached to a single artist. Users may want to restrict this search to only show releases of a specific type (such as albums or compilations). This CR adds a new --release-type flag to the missing plugin. If users want to filter to a specific type (or set of types), they simply need to provide this flag for every release type that they want included.

As part of this change, the default behavior has been shifted to only select album type releases as is suggested in the issue- to avoid breaking default behavior I could easily switch this back. I am also wondering if it might make sense to address the following idea (#5101) in a follow-up.

The tests I wrote are written using pytest, as it is suggested in the documentation to stay away from unittest. As a result, I required a slightly different mixin inheritance schema than is usually seen. If there are any other recommended ways to accomplish this I'd be happy to switch!

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant