Support using system CMake and Ninja when available #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the requirements for `cmake` and `ninja` PyPI packages only when the respective system tools are not available, in order to permit using the system tools instead. This avoids unnecessary dependencies on third-party executables, and permits users to benefit from greater portability due to downstream patching of CMake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the requirements for
cmakeandninjaPyPI packages only when the respective system tools are not available, in order to permit using the system tools instead. This avoids unnecessary dependencies on third-party executables, and permits users to benefit from greater portability due to downstream patching of CMake.