Fix paths in hashed files #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working with all relative paths + absolute path Replace in hashed files instead of original files
If css/app.css is to be replaced with a hashed version, don't replace css/app.css in subdirs.
|
@HollandBen are you willing to accept (or at least review) this PR? Can I help to get this merged? |
|
Can we please merge this PR, I have encountered the similar issue regarding the relative path as well. Thanks. |
|
@HollandBen are you planning to do something with this PR? |
|
Hi @richardhinkamp and @zacyang. It appears these changes have broken parsing of files that include an "alternate syntax" (#214). I've created a test for it that is currently failing and pushed it into the |
|
Thanks for merging @HollandBen ! I will comment in #214 about that issue |
hemberger
added a commit
to hemberger/smr
that referenced
this pull request
Feb 16, 2021
The behavior of this package has changed since v1.4.1, such that the replacements are made in files with a strict adherence to relative paths from the `baseDir` option. Since many of our PHP files aren't located where they are served from (e.g. templates, includes, etc.), grunt-cache-bust doesn't bust these files anymore. The easiest fix is reference all JS/CSS with absolute URL paths (e.g. `css/Default.css` -> `/css/Default.css`). While this is not an ideal solution, due to its degradation of our support for serving the game from a subdirectory (e.g. `http://localhost/smr` instead of just `http://localhost`), it solves the problem for our current dev and production configurations. See benhoIIand/grunt-cache-bust#211 for the PR that introduced this breaking change. See benhoIIand/grunt-cache-bust#236 for a summary of how this change impacted our usage. Thanks to @Page- for the deep dive into grunt-cache-bust!
hemberger
added a commit
to hemberger/smr
that referenced
this pull request
Feb 17, 2021
The behavior of this package has changed since v1.4.1, such that the replacements are made in files with a strict adherence to relative paths from the `baseDir` option. Since many of our PHP files aren't located where they are served from (e.g. templates, includes, etc.), grunt-cache-bust doesn't bust these files anymore. The easiest fix is reference all JS/CSS with absolute URL paths (e.g. `css/Default.css` -> `/css/Default.css`). While this is not an ideal solution, due to its degradation of our support for serving the game from a subdirectory (e.g. `http://localhost/smr` instead of just `http://localhost`), it solves the problem for our current dev and production configurations. See benhoIIand/grunt-cache-bust#211 for the PR that introduced this breaking change. See benhoIIand/grunt-cache-bust#236 for a summary of how this change impacted our usage. Thanks to @Page- for the deep dive into grunt-cache-bust!
hemberger
added a commit
to smrealms/smr
that referenced
this pull request
Feb 21, 2021
The behavior of this package has changed since v1.4.1, such that the replacements are made in files with a strict adherence to relative paths from the `baseDir` option. Since many of our PHP files aren't located where they are served from (e.g. templates, includes, etc.), grunt-cache-bust doesn't bust these files anymore. The easiest fix is reference all JS/CSS with absolute URL paths (e.g. `css/Default.css` -> `/css/Default.css`). While this is not an ideal solution, due to its degradation of our support for serving the game from a subdirectory (e.g. `http://localhost/smr` instead of just `http://localhost`), it solves the problem for our current dev and production configurations. See benhoIIand/grunt-cache-bust#211 for the PR that introduced this breaking change. See benhoIIand/grunt-cache-bust#236 for a summary of how this change impacted our usage. Thanks to @Page- for the deep dive into grunt-cache-bust!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #207
It correctly identifies all relative paths from the source file to the hashed filename, including the absolute path.
The replace is smarter now, a replace of "css/app.css" would also replace "lib/css/app.css", which is incorrect. So now the filename is only replaced in these cases, enclosed by:
"{file}"'{file}'({file})(css url(...))={file}>(unquoted html attribute)={file}\s(unquoted html attribute followed by more attributes)Since the filename may contain a querystring, the closing char may also be a '?'.
I created a new unit test for this.
If a file is copied to a hashed filename, replacing will now happen in the hashed file instead of the original file, since the original file will not be used (and maybe even be deleted).If a full filename is specified as source instead of a wildcard and that file is busted, the source cannot be found when replacing in files. It now correctly handles this cases and translated the filename to the busted filename.
All the test still work and the test project in the issue also works as expected. I hope this a correct change which can be merged, I would love to get some feedback on it.
Richard