chore(blockchain) : non optimistic client should not request build optimistically #2240

nidhi-singh02 · 2024-12-11T07:33:12Z

Non optimistic client currently request for build optimistically, fixing it with this changeset.

Signed-off-by: nidhi-singh02 <[email protected]>

coderabbitai · 2024-12-11T07:33:19Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-12-11T07:35:30Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.88%. Comparing base (8e9e4a1) to head (5ab9446).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
beacon/blockchain/execution_engine.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2240      +/-   ##
==========================================
+ Coverage   30.78%   30.88%   +0.10%     
==========================================
  Files         331      331              
  Lines       15372    15321      -51     
  Branches       20       20              
==========================================
  Hits         4732     4732              
+ Misses      10319    10268      -51     
  Partials      321      321

Files with missing lines	Coverage Δ
beacon/blockchain/execution_engine.go	`0.00% <0.00%> (ø)`

nidhi-singh02 · 2024-12-11T08:41:30Z

E2E tests are failing, seems blocks finalisation count is stuck in tests. I am debugging it.

shotes · 2024-12-11T17:30:13Z

I believe the check for shouldBuildOptimisticPayloads() should be removed. This sendPostBlockFCU() function should always call s.sendNextFCUWithoutAttributes(ctx, blk, lph) whether it is optimistic or not, since all nodes need to notify the execution layer of the fork choice update.

Do note that removing the call to s.sendNextFCUWithAttributes(ctx, st, blk, lph) fixed the issue with triggering optimistic builds - this function should never trigger optimistic builds by sending FCU with attributes.

Signed-off-by: Nidhi Singh <[email protected]>

Signed-off-by: nidhi-singh02 <[email protected]>

nidhi-singh02 · 2024-12-12T06:43:59Z

I believe the check for shouldBuildOptimisticPayloads() should be removed. This sendPostBlockFCU() function should always call s.sendNextFCUWithoutAttributes(ctx, blk, lph) whether it is optimistic or not, since all nodes need to notify the execution layer of the fork choice update.

Do note that removing the call to s.sendNextFCUWithAttributes(ctx, st, blk, lph) fixed the issue with triggering optimistic builds - this function should never trigger optimistic builds by sending FCU with attributes.

Makes sense, removing the check worked. Thanks for your valuable pointers @shotes!

Signed-off-by: Nidhi Singh <[email protected]>

abi87 · 2024-12-13T15:32:55Z

beacon/blockchain/execution_engine.go

+// block is finalized.This function should only be used to notify
+// the EL client of the new head and should not request optimistic builds, as:
+// Optimistic clients already request builds in handleOptimisticPayloadBuild()
+// Non-optimistic clients should never request optimistic builds.


q: this function is still called in its own goroutine. Is this necessary? Can we call it synchronously? @nidhi-singh02 @shotes

beacon/blockchain/execution_engine.go

abi87

nits and a couple of questions

Signed-off-by: Nidhi Singh <[email protected]>

Signed-off-by: nidhi-singh02 <[email protected]>

abi87

lgtm

nidhi-singh02 added 2 commits December 11, 2024 12:43

non optimistic client should not sendnextFCU without attributes

514f98e

Signed-off-by: nidhi-singh02 <[email protected]>

linter

1b68882

Signed-off-by: nidhi-singh02 <[email protected]>

nidhi-singh02 requested review from itsdevbear and abi87 as code owners December 11, 2024 07:33

nidhi-singh02 requested review from fridrik01 and calbera December 11, 2024 07:44

nidhi-singh02 added the Ready for Review label Dec 11, 2024

nidhi-singh02 marked this pull request as draft December 11, 2024 08:53

nidhi-singh02 added 2 commits December 12, 2024 11:51

Merge branch 'main' into optimistic-builder

395fdea

Signed-off-by: Nidhi Singh <[email protected]>

e2e fix

a2c93c1

Signed-off-by: nidhi-singh02 <[email protected]>

nidhi-singh02 marked this pull request as ready for review December 12, 2024 06:44

Merge branch 'main' into optimistic-builder

75c0952

Signed-off-by: Nidhi Singh <[email protected]>

abi87 reviewed Dec 13, 2024

View reviewed changes

beacon/blockchain/execution_engine.go Outdated Show resolved Hide resolved

abi87 reviewed Dec 13, 2024

View reviewed changes

beacon/blockchain/execution_engine.go Outdated Show resolved Hide resolved

abi87 reviewed Dec 13, 2024

View reviewed changes

nidhi-singh02 added 3 commits December 16, 2024 11:51

Merge branch 'main' into optimistic-builder

7040e7e

Signed-off-by: Nidhi Singh <[email protected]>

moved func into the calling func

d3ca039

Signed-off-by: nidhi-singh02 <[email protected]>

lint fix

5ab9446

Signed-off-by: nidhi-singh02 <[email protected]>

nidhi-singh02 requested a review from abi87 December 16, 2024 06:48

abi87 approved these changes Dec 16, 2024

View reviewed changes

abi87 merged commit cc31590 into main Dec 16, 2024
16 checks passed

abi87 deleted the optimistic-builder branch December 16, 2024 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(blockchain) : non optimistic client should not request build optimistically #2240

chore(blockchain) : non optimistic client should not request build optimistically #2240

nidhi-singh02 commented Dec 11, 2024 •

edited

Loading

coderabbitai bot commented Dec 11, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Dec 11, 2024 •

edited

Loading

nidhi-singh02 commented Dec 11, 2024 •

edited

Loading

shotes commented Dec 11, 2024 •

edited

Loading

nidhi-singh02 commented Dec 12, 2024

abi87 Dec 13, 2024

abi87 left a comment

abi87 left a comment

chore(blockchain) : non optimistic client should not request build optimistically #2240

chore(blockchain) : non optimistic client should not request build optimistically #2240

Conversation

nidhi-singh02 commented Dec 11, 2024 • edited Loading

coderabbitai bot commented Dec 11, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Dec 11, 2024 • edited Loading

Codecov Report

nidhi-singh02 commented Dec 11, 2024 • edited Loading

shotes commented Dec 11, 2024 • edited Loading

nidhi-singh02 commented Dec 12, 2024

abi87 Dec 13, 2024

Choose a reason for hiding this comment

abi87 left a comment

Choose a reason for hiding this comment

abi87 left a comment

Choose a reason for hiding this comment

nidhi-singh02 commented Dec 11, 2024 •

edited

Loading

coderabbitai bot commented Dec 11, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Dec 11, 2024 •

edited

Loading

nidhi-singh02 commented Dec 11, 2024 •

edited

Loading

shotes commented Dec 11, 2024 •

edited

Loading