Use the correct partialTick when ticking animations #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #671 after I realized there was a better approach after surfing through the code again. This version of the PR passes the proper
partialTicktohandleAnimationsas I found out the proper one is used everywhere EXCEPT the place that needs it most.I only messed with this method as it was marked as internal so people shouldn't be messing with it anyway. I do however, recognize
setCustomAnimationswould also needpartialTickpassed in and I didn't want to do that since that one is an actual API method. I will either leave that for you guys to do or I can do it if the go ahead is given.If this PR is accepted I will also open one for 1.21 if that's cool(EDIT: after looking over 1.21 it already does this. No need for another PR). 1.21 and 1.21.4 will also needpartialTickpassed intosetCustomAnimationsif thats done here too. Thanks for looking over this :)