Endgame screen with rmlui

[patroldo]

Work done

Test steps

• to check endgamescreen in 1v1(few games which can produce or not produce some awards
• to check endgamescreen in 2v2(few games which can produce or not produce some awards)
• to check endgamescreen in 3v3(few games which can produce or not produce some awards)
• to check endgamescreen in 8v8(few games which can produce or not produce some awards)
• to check endgamescreen in coop(few games which can produce or not produce some awards)
• try few other languages

Screenshots:

BEFORE:

AFTER:

NOTE: On Second screen position of buttons is corrected

[patroldo]

Example from real game. Unfortunantly translations didn't worked, but this is only due to some "workaround" to hook engine with my LuaUI in order to run replay. In actual game text is looking good

[patroldo]

Progress + conversation in discord:
https://discord.com/channels/549281623154229250/1333885512364195891

[WatchTheFort]

These additional entries shouldn't be needed. We need to be able to use the interpolated string entries, so if those aren't working, we need to fix that.

[patroldo]

interpolated you mean those, which already presented. Right?

[WatchTheFort]

The ones that contain variables. "Lorum ipsum %{interpolatedVariable}"

[patroldo]

Not sure if rml supports interpolated, at least didn't find it in the doc. There're 2 things which are coming into my mind in order to work with such strings:

1. Once game ended - dynamically put into RmlUi translations string with interpolated values. I mean already replaced variable with time and only then put it into RmlUi translation table
2. In order to translate such string, use I18N in lua widget and pass it via documentHandler model. In this case we just avoid using RmlUi translation table

Not sure which approach is better

[WatchTheFort]

These are specific a single widget, they should not be in the general rmlui setup code.

[patroldo]

From one side - agree. From another - i would say widget is not the right place to work with translations. I think separate module need to work with translations for RmlUi including handling of changing language

[WatchTheFort]

This question is being handled in #4387

[WatchTheFort]

This needs to support translation

[patroldo]

That is a tricky one tbh. Translations can be there using I18N. But let's take few examples of time-translations. English-Ukrainian:
a) 21 minute - "21 хвилина"
b) 22 minutes - "22 хвилини"
c) 23 minutes - "23 хвилини"
d) 25 minutes - "25 хвилин"

The point is that time cannot be translated 1:1 into every language as every language may have unique ending or suffix or similar. Thus separated module needs to handle translations of time. On the other hand - even if time will be slightly incorrect, maybe not a big deal as mainly it should show statistics and doesn't mean translation should be accurate in all and every place. What do you think?

[WatchTheFort]

The I18N library we use has pluralization support, we just haven't used it yet.
https://github.com/gajop/i18n?tab=readme-ov-file#pluralization

Any string we display on the UI needs to support translation.

[WatchTheFort]

The folder structure has now been settled on, please rearrange as follows:

\luaui
  \RmlWidgets
    \gui_awards
      gui_awards.lua
      gui_awards.rcss
      gui_awards.rml

You will have to create the RmlWidgets folder, since this will be the first rml widget added to the repo.

[patroldo]

The folder structure has now been settled on, please rearrange as follows:

\luaui
  \RmlWidgets
    \gui_awards
      gui_awards.lua
      gui_awards.rcss
      gui_awards.rml

You will have to create the RmlWidgets folder, since this will be the first rml widget added to the repo.

Already done :)