T2 Constructor Sharing Mode #4447
Open
+50
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes automatic enabling and locking of unit sharing and assist construction settings when resource sharing tax is non-zero. Each setting now operates independently. gh beyond-all-reason#4415
- Remove redundant whitelist and AllowUnitTransfer implementation - Remove unused disable_unit_sharing and unitSharingMode variables - Rely solely on unitPrice unit rules parameter for transfer control - Clean up code to use standardized Spring unit rules parameter system This change simplifies the unit market code by removing redundant unit sharing checks that were previously used alongside the whitelist system. Now the market relies solely on the unitPrice unit rules parameter to handle unit transfers, which is properly checked by game_disable_unit_sharing.lua. This makes the code cleaner and removes potential conflicts between the two gadgets.
Adds a middle ground between full unit sharing and no sharing by allowing only T2 mobile constructors to be transferred between allies. This enables strategic sharing of build power while maintaining unit ownership separation. gh beyond-all-reason#4416
Rename disable_unit_sharing to unit_sharing_mode to better reflect its current function as a multi-mode control rather than a simple disable switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4416
Note for PR mergers: This is downstream and contains commits from #4433
T2 Constructor Sharing Mode
This implementation converts the "Disable Unit Sharing" option into a dropdown with three choices as requested:
Implementation Approach
Testing Results
Verified with various unit types:
The implementation successfully provides the middle ground option requested in the original PR, allowing strategic sharing of build power while maintaining unit ownership boundaries.
Before
After