Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the crate from the repo and async-std #238

Closed
wants to merge 1 commit into from

Conversation

hfiguiere
Copy link
Contributor

  1. so that we always build with the latest.
  2. fix feature so that it actually work.

@A6GibKm
Copy link
Collaborator

A6GibKm commented Oct 2, 2024

Unfortunately, it is not possible to build the demo with GNOME Builder due to the same error seen on CI.

@bilelmoussaoui
Copy link
Owner

The demo is never meant to use the git version of ashpd. Because of two reasons:

  • The one stated above by Maximilano. You can't make it work without opening a sandbox hole
  • When a new breaking API release of gtk4-rs is around the corner, we switch to use it in ashpd main allowing people to try the latest APIs, if we ever merge something like this PR, I will have to update the demo continuously which something I don't want to.

I know it makes things easier for developing a new portal implementation, by having a very easy way to test it. But you don't really need a GUI for it.

The GUI is targeting distributions and users to debug portals, not writing ones.

@bilelmoussaoui
Copy link
Owner

A similar patch is now in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants