Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For geneontology/pipeline#408 #702

Merged
merged 2 commits into from
Dec 14, 2024
Merged

For geneontology/pipeline#408 #702

merged 2 commits into from
Dec 14, 2024

Conversation

mugitty
Copy link
Collaborator

@mugitty mugitty commented Dec 13, 2024

No description provided.

@mugitty mugitty requested a review from dustine32 December 13, 2024 02:03
dustine32
dustine32 approved these changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change correctly matches the right part of an MGI ID ex: "MGI:12345" vs "12345" against the db-xref pattern entry. Code change looks good and tests work. Thanks @mugitty!

@mugitty mugitty merged commit 5a3da4f into master Dec 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustine32 dustine32 dustine32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mugitty @dustine32