Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop using directories outside of OUT_DIR in build time #65

Merged
merged 5 commits into from
Dec 23, 2024

Conversation

nicolasauler
Copy link
Member

Description

From cargo documentation (https://doc.rust-lang.org/cargo/reference/environment-variables.html):

In general, build scripts should not modify any files outside of OUT_DIR. It may seem fine on the first blush, but it does cause problems when you use such crate as a dependency, because there’s an implicit invariant that sources in .cargo/registry should be immutable. cargo won’t allow such scripts when packaging.

This indeed is happening when I try to run nix related shenanigans on Bipa Server, due to this dependency not following this guideline.

@nicolasauler nicolasauler merged commit bceeb2a into master Dec 23, 2024
1 check passed
@nicolasauler nicolasauler deleted the fix-build branch December 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants