Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): improve dependency check and error message in autogen.sh #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

epiccurious
Copy link

@epiccurious epiccurious commented Aug 13, 2024

Three changes:

  1. Improve error reporting in autogen.sh by redirecting the autoreconf dependency check's error message to stderr.
  2. Use command -v instead of which in the script.
  3. Replace legacy backtick substitution with modern $(...) command substitution.

Impact

This PR modifies autogen.sh in the root directory.

  • No change to the functional behavior of these files.
  • Enhances error reporting by directing error messages to stderr, aligning with best practices.
  • Improves portability/reliability by using command -v instead of which. (Link to ShellCheck rule for context.)
  • Improves portability/reliability by using modern $(...) command substitution. (Link to Shellcheck rule for context.)

Background

5 years ago: Created the entire file with no other updates.

@epiccurious epiccurious marked this pull request as draft August 14, 2024 16:39
@epiccurious epiccurious marked this pull request as ready for review August 14, 2024 16:44
@epiccurious
Copy link
Author

Reopened PR with an addition change ("3." in the description).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant