Use TaskStackBuilder instead of PendingIntent.getActivity

[ArnyminerZ]

Purpose

The current state-of-the-art seems to be TaskStackBuilder, also for Compose deep links.

Short description

Replaced all usages of PendingIntent.getActivity with the equivalent TaskStackBuilder.

Checklist

• The PR has a proper title, description and label.
• I have self-reviewed the PR.
• I have added documentation to complex functions and functions that can be used by other modules.
• I have added reasonable tests or consciously decided to not add tests.

[sunkup]

I am not completely sure, so please tell me, what is the reasoning for using addNextIntent over addNextIntentWithParentStack in all our use cases?

[sunkup]

Added an unused import here

[sunkup]

It's still there. ARG_SERVICE_ID does not need to be imported for the usages in it's own file.

[ArnyminerZ]

I am not completely sure, so please tell me, what is the reasoning for using addNextIntent over addNextIntentWithParentStack in all our use cases?

As far as I my understanding goes, addNextIntentWithParentStack would allow going back from the launched activity all the way to the main one, and addNextIntent will only launch the given activity.

So if you always use addNextIntent, going back should close the app? Not sure about this one

[sunkup]

I am not completely sure, so please tell me, what is the reasoning for using addNextIntent over addNextIntentWithParentStack in all our use cases?

As far as I my understanding goes, addNextIntentWithParentStack would allow going back from the launched activity all the way to the main one, and addNextIntent will only launch the given activity.

So if you always use addNextIntent, going back should close the app? Not sure about this one

ok. So is that what we want in every case?

[ArnyminerZ]

ok. So is that what we want in every case?

I don't actually know. I think it's more of a personal choice. When accessing from a notification for example, do we want that going back closes the app or navigates back?

[sunkup]

ok. So is that what we want in every case?

I don't actually know. I think it's more of a personal choice. When accessing from a notification for example, do we want that going back closes the app or navigates back?

Should there not be something about that expected user expierence somewhere in the docs? Like maybe in the material guide lines?

Personally I would always expect that going back will navigate back - not close the app.

[sunkup]

Although we don't use actual deeplinks yet, I would argue that's what we do when entering a deep screen through a notification. This is the expected behaviour:

https://developer.android.com/guide/navigation/design/deep-link#explicit

https://developer.android.com/guide/navigation/principles#deep-link

Also interesting:
https://m2.material.io/design/navigation/understanding-navigation.html

[ArnyminerZ]

Although we don't use actual deeplinks yet

I think that even though we don't use deeplinks, we kind of have a navigation graph, so I agree that we should act like we have them.

[ArnyminerZ]

To sum things up, I think I am going to replace all PendingIntents of activities other than AccountsActivity with addNextIntentWithParentStack, that way the whole stack would be added, and going back would match the expected behavior, and the recommended one by Google.

[ArnyminerZ]

I've merged main into here, and replaced some usages. I've left some ACTION_VIEW intents with addNextIntent because as far as I understand, implicit intents would not have any stack or matching activity to build it from, right?