Added confirmation dialog for "Distrust System Certificates" #1307
+51
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <[email protected]>
|
|
Signed-off-by: Arnau Mora <[email protected]>
ArnyminerZ
changed the title
sunkup
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Works well :)
I would probably write something different, though - but we can also stick to your version. The most important is to have the user understand they are doing some potentially functionality breaking changes.
Title: "Attention!"
Text: "Enabling this option will cause DAVx5 to distrust system certificates. You will need to manually install the required certificates. This option is intended for advanced users."
Screenshot
What do you think? Also how about a preview of the card?
app/src/main/kotlin/at/bitfire/davdroid/ui/AppSettingsScreen.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora <[email protected]>
|
Added preview: Image
|
|
I've also updated the text as you've said. @devvv4ever anything to change? See screenshot above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
See #1294
Short description
Checklist