-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added backup export and import #145
Conversation
Signed-off-by: Arnau Mora <[email protected]>
Currently export works. I've tried exporting a backup file, and taking a look at it using DB Browser for SQLite and it does show the data correctly. However, exporting has some implications:
Edit: now import is working. The database file must be removed, otherwise |
Signed-off-by: Arnau Mora <[email protected]>
TODO:
|
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
@sunkup what do you think? Should we add the possibility of backups? Maybe only enabling the automatic ones? Otherwise this PR would be good, it's just a matter of updating the UI to Compose. |
Really nice feature to look at. Personally I don't have that many calendars - but I guess it might prove useful for a handful of people. Does the code handle migrations already? How do you think this would integrate once ICSx5 becomes part of DAVx5 ? Could that become an issue? Since DAVx5 will have complete app backups, would that not make this feature obsolete? |
I think we should just take the automatic backup part, and get rid of manual backups as of right now. Simply store the subscriptions made so that if the device is formatted all of them can be added back again. Maybe once we add backups to DAVx5, we can consider them here as well, or directly inside of DAVx5. It will be for sure a big task, and we don't want to have two different kinds of backups, so it's better to wait until we design a format for DAVx5, and then either implement that one here as well, or simply everything into DAVx5. |
Sorry, I don't understand this. In my head:
Which automatic backup part do you want to get rid of? Do you want to merge this feature or not? 😅 |
What I mean by automatic backups are the ones made automatically by Android: https://developer.android.com/guide/topics/data/autobackup Manual backups would be the user saying: okay, I want to create a backup of the database which I can then import manually. I've been thinking about this for a while. Right now automatic backups are enabled, I thought they weren't. The database name is configured here:
and then the extraction rules are specified here: icsx5/app/src/main/res/xml/data_extraction_rules.xml Lines 1 to 9 in a77733b
and here icsx5/app/src/main/res/xml/backup_rules.xml Lines 1 to 6 in a77733b
After much consideration, since the database of ICSx5 is quite simple, we can pretty much consider a backup creating a SQL file of the database, which uses SQLite. By how Room is designed, we can import this file later on. This is what I did originally in this PR, but a lot has to be modified in order to work with the new UI. I believe the best approach would be to create a new PR copying and pasting most of what's here |
Ah ok. How are migrations handled for automatic backups then? And how do you think this would integrate once ICSx5 becomes part of DAVx5 ? Could that become an issue? Since DAVx5 will have complete app backups, would that not make this feature obsolete / hard to integrate with DAVx5? Sorry for being so hesitant with this, but I'd like to avoid unnecessary work. :) @devvv4ever Said they want to merge ICSx5 into DAVx5 this year already |
I'll close this. We will implement it in DAVx5 at some point in the future. |
Closes #144