bug: fix concurrent same-row mutations #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehiah
force-pushed
the
concurrent_mutations_11
branch
from
792bfbb
to
967f764
Compare
pevans96
approved these changes
Feb 14, 2024
jehiah
force-pushed
the
concurrent_mutations_11
branch
from
967f764
to
e1899ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the underlying datastore
rows_tis single-row per rowKey all row operations involve a datastore get() followed by update/insert; this means there is a race condition with concurrent updates where intermediate updates are lost.This adds table level locking to serialize operations. The goal for this emulator isn't fast it's correct and persistent.